-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/auto browser and bad query fallback #9
Feat/auto browser and bad query fallback #9
Conversation
I like the automatically opening the URL thing, but i don't like the "No such resource returned ..." thing, i prefer the skeleton. If you remove the that i will merge this PR. |
do you think skeleton would make sense for the users who aint know whether their query fails or not.. or we can stop the loading skeleon if the query fails to do so. |
Ok yeah, we should do this
Since i want people to directly type in their queries and have the data fetched automatically, i don't want them to be bombarded with a "No such resource error". |
yeah we can handle that by debouncing but yeah it is better to return a nothing. |
Yeah but don't add debouncing. I want querying to feel extremely fast, deboucing will just add a delay. Since people are running the server on their own local machine, we don't care about how many times they hit the |
hmmm....makes sense , it is fixed by now |
This change include